Added ViaRequest interceptor#387
Merged
Merged
Conversation
Member
|
@arturobernalg Please change the target branch to |
arturobernalg
force-pushed
the
feature/via-interceptor
branch
from
e3cce0d to
36d1205
Compare
arturobernalg
force-pushed
the
feature/via-interceptor
branch
2 times, most recently
from
701f3b9 to
6d2ab42
Compare
Member
Author
@ok2c Done |
ok2c
requested changes
Feb 9, 2023
| Args.notNull(context, "HTTP context"); | ||
| final ProtocolVersion ver = context.getProtocolVersion() != null ? context.getProtocolVersion() : HttpVersion.HTTP_1_1; | ||
|
|
||
| final Header host = request.getHeader(HttpHeaders.HOST); |
Member
There was a problem hiding this comment.
@arturobernalg What happens if this interceptor gets added to an HTTP/2 message pipeline wherein Host header is illegal? I think you should be using HttpRequest#getAuthority instead.
Member
There was a problem hiding this comment.
Merged. Thank you, @arturobernalg, for this contribution.
arturobernalg
force-pushed
the
feature/via-interceptor
branch
from
e6077e5 to
701f668
Compare
ok2c
reviewed
Feb 10, 2023
arturobernalg
force-pushed
the
feature/via-interceptor
branch
from
0ef4af6 to
077113e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.